Repository navigation
test(website): read the rendered docs heading in the React docs parity spec - #1612
Merged
Merged
Conversation
…y spec Under next dev the article streams behind a Suspense boundary, so for a moment its copy in React's hidden segment holder exists beside the one the workspace shell shows. A bare h1 locator then matched two elements and failed in strict mode. Look the heading up by role, which skips the hidden copy.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/website/e2e/react-docs-parity.spec.ts("framework switching and shared pages keep the docs reading theme") failed intermittently in "Website — e2e (control-plane)", most recently on the first CI attempt of #1609, with a strict-mode violation:locator('h1')resolved to two elements on/docs/choosing-an-adapter.Cause
The e2e job serves the site with
next dev. In developmentMdxRendererwraps the article in aSuspenseboundary, so the article streams after the shell. For a moment the streamed copy still sits in React's hidden segment holder (S:0) while the workspace shell already shows its own copy. A probe recorded this on 3 of 12 loads, for about 20 ms each:A strict locator throws as soon as it sees two matches, so the window does not have to last. A visitor never sees the hidden copy, and production does not render the boundary.
Change
The spec looks the heading up by role and name, which reads rendered elements only. No product code changes.
Verification
next devserver with the same strict-mode violation.npx nx lint websitepasses.Not run: the full website e2e suite locally; CI covers it.
🤖 Generated with Claude Code